From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix test_decoding's handling of nonexistant columns in old tuple |
Date: | 2015-06-27 17:23:16 |
Message-ID: | E1Z8toy-0006U2-JK@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix test_decoding's handling of nonexistant columns in old tuple versions.
test_decoding used fastgetattr() to extract column values. That's wrong
when decoding updates and deletes if a table's replica identity is set
to FULL and new columns have been added since the old version of the
tuple was created. Due to the lack of a crosscheck with the datum's
natts values an invalid value will be output, leading to errors or
worse.
Bug: #13470
Reported-By: Krzysztof Kotlarski
Discussion: 20150626100333(dot)3874(dot)90852(at)wrigleys(dot)postgresql(dot)org
Backpatch to 9.4, where the feature, including the bug, was added.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/ed6c8d73619a69c8751c8662242fdce22d31bc42
Modified Files
--------------
contrib/test_decoding/expected/ddl.out | 14 ++++++++++++--
contrib/test_decoding/sql/ddl.sql | 4 ++++
contrib/test_decoding/test_decoding.c | 2 +-
3 files changed, 17 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-06-27 21:47:46 | pgsql: Avoid passing NULL to memcmp() in lookups of zero-argument funct |
Previous Message | Andres Freund | 2015-06-27 17:23:15 | pgsql: Fix test_decoding's handling of nonexistant columns in old tuple |