pgsql: Improve error message and hint for ALTER COLUMN TYPE can't-cast

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve error message and hint for ALTER COLUMN TYPE can't-cast
Date: 2015-06-12 15:54:24
Message-ID: E1Z3RHk-0006AP-JP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve error message and hint for ALTER COLUMN TYPE can't-cast failure.

We already tried to improve this once, but the "improved" text was rather
off-target if you had provided a USING clause. Also, it seems helpful
to provide the exact text of a suggested USING clause, so users can just
copy-and-paste it when needed. Per complaint from Keith Rarick and a
suggestion from Merlin Moncure.

Back-patch to 9.2 where the current wording was adopted.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b00982344a73d9cb626430dd17a6da84c15c9980

Modified Files
--------------
src/backend/commands/tablecmds.c | 25 ++++++++++++++++++++-----
src/test/regress/expected/alter_table.out | 7 +++++--
src/test/regress/sql/alter_table.sql | 1 +
3 files changed, 26 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-06-12 17:44:13 pgsql: Fix failure to cover scalar-vs-rowtype cases in exec_stmt_return
Previous Message Fujii Masao 2015-06-12 14:12:35 pgsql: Make postmaster restart archiver soon after it dies, even during