pgsql: Tighten the per-operator testing done in brin regression test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Tighten the per-operator testing done in brin regression test.
Date: 2015-06-04 18:39:56
Message-ID: E1Z0a3Y-0000kV-5c@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tighten the per-operator testing done in brin regression test.

Verify that the number of matches is exactly what it should be, not just
that it not be zero. This should help us detect any environment-dependent
issues.

Also, verify that we're getting the expected type of scan plan (either
bitmap or seqscan as appropriate). Right now, this is failing on the
cidrcol test cases, as shown in the output file. I'll look into that
in a bit, but it seems good to commit this as-is temporarily to verify
that it behaves as expected on the buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/79454c696bd3346a9f00f5e940398fb01a337fad

Modified Files
--------------
src/test/regress/expected/brin.out | 295 +++++++++++++++++++++++++++++-------
src/test/regress/sql/brin.sql | 267 +++++++++++++++++++++++++-------
2 files changed, 458 insertions(+), 104 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-06-04 19:24:28 pgsql: Fix brin regression test so it actually tests cidr.
Previous Message Alvaro Herrera 2015-06-04 18:21:52 pgsql: pgindent run on access/transam/multixact.c