From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Stabilize results of brin regression test. |
Date: | 2015-06-04 17:46:38 |
Message-ID: | E1Z0ZDy-0008MB-PS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Stabilize results of brin regression test.
This test used seqscans on tenk1, with LIMIT, to build test data.
That works most of the time, but if the synchronized-seqscan logic
kicks in, we get varying test data. This seems likely to explain
the erratic test failures on buildfarm member chipmunk, which uses
smaller-than-default shared_buffers. To fix, add ORDER BY clauses to
force the ordering to be what it was implicitly being assumed to be.
Peter Geoghegan had noticed this with respect to one of the trouble
spots, though not the ones actually causing the chipmunk issue.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/bac99475eb6e9e6d69a91fee30b5420b8e0115be
Modified Files
--------------
src/test/regress/expected/brin.out | 6 +++---
src/test/regress/sql/brin.sql | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-06-04 17:50:35 | pgsql: Fix brin "char" test to actually test what it meant to test. |
Previous Message | Andrew Dunstan | 2015-06-04 15:13:01 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |