| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix parse tree of DROP TRANSFORM and COMMENT ON TRANSFORM |
| Date: | 2015-05-19 03:02:14 |
| Message-ID: | E1YuXnK-0001tW-Vw@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix parse tree of DROP TRANSFORM and COMMENT ON TRANSFORM
The plain C string language name needs to be wrapped in makeString() so
that the parse tree is copyable. This is detectable by
-DCOPY_PARSE_PLAN_TREES. Add a test case for the COMMENT case.
Also make the quoting in the error messages more consistent.
discovered by Tom Lane
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/0779f2ba2db6787259f3ea82f999e08552724218
Modified Files
--------------
contrib/hstore_plperl/expected/create_transform.out | 7 ++++---
contrib/hstore_plperl/sql/create_transform.sql | 2 ++
src/backend/catalog/objectaddress.c | 2 +-
src/backend/commands/dropcmds.c | 4 ++--
src/backend/commands/functioncmds.c | 2 +-
src/backend/parser/gram.y | 6 +++---
6 files changed, 13 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-05-19 12:59:06 | Re: pgsql: hstore_plpython: Fix regression tests under Python 3 |
| Previous Message | Tom Lane | 2015-05-19 00:20:45 | Re: pgsql: Change pg_seclabel.provider and pg_shseclabel.provider to type " |