pgsql: Put back a backwards-compatible version of sampling support func

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Put back a backwards-compatible version of sampling support func
Date: 2015-05-18 22:34:55
Message-ID: E1YuTcd-000665-Ai@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Put back a backwards-compatible version of sampling support functions.

Commit 83e176ec18d2a91dbea1d0d1bd94c38dc47cd77c removed the longstanding
support functions for block sampling without any consideration of the
impact this would have on third-party FDWs. The new API is not notably
more functional for FDWs than the old, so forcing them to change doesn't
seem like a good thing. We can provide the old API as a wrapper (more
or less) around the new one for a minimal amount of extra code.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4db485e75b9672126963ae4052b50f473b30a097

Modified Files
--------------
src/backend/utils/misc/sampling.c | 46 ++++++++++++++++++++++++++++++++++++-
src/include/commands/vacuum.h | 5 ++++
src/include/utils/sampling.h | 16 ++++++++++---
3 files changed, 63 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-18 22:36:16 Re: pgsql: Separate block sampling functions
Previous Message Alvaro Herrera 2015-05-18 20:44:21 pgsql: Don't MultiXactIdIsRunning when in recovery