pgsql: At promotion, archive last segment from old timeline with .parti

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: At promotion, archive last segment from old timeline with .parti
Date: 2015-05-08 19:07:42
Message-ID: E1Yqncc-0001lK-Ss@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

At promotion, archive last segment from old timeline with .partial suffix.

Previously, we would archive the possible-incomplete WAL segment with its
normal filename, but that causes trouble if the server owning that timeline
is still running, and tries to archive the same segment later. It's not nice
for the standby to trip up the master's archival like that. And it's pretty
confusing, anyway, to have an incomplete segment in the archive that's
indistinguishable from a normal, complete segment.

To avoid such confusion, add a .partial suffix to the file. Or to be more
precise, make a copy of the old segment under the .partial suffix, and
archive that instead of the original file. pg_receivexlog also uses the
.partial suffix for the same purpose, to tell apart incompletely streamed
files from complete ones.

There is no automatic mechanism to use the .partial files at recovery, so
they will go unused, unless the administrator manually copies to them to
the pg_xlog directory (and removes the .partial suffix). Recovery won't
normally need the WAL - when recovering to the new timeline, it will find
the same WAL on the first segment on the new timeline instead - but it
nevertheless feels better to archive the file with the .partial suffix, for
debugging purposes if nothing else.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/de7688442f5aaa03da60416a6aa3474738718803

Modified Files
--------------
src/backend/access/transam/xlog.c | 133 +++++++++++++++++++++++++++---------
src/include/access/xlog_internal.h | 5 ++
src/include/postmaster/pgarch.h | 2 +-
3 files changed, 107 insertions(+), 33 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-05-08 20:28:56 pgsql: Fix two problems in infer_arbiter_indexes().
Previous Message Peter Eisentraut 2015-05-08 18:46:14 pgsql: Fix whitespace

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-05-08 19:09:47 Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Previous Message Tom Lane 2015-05-08 19:07:38 Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0