pgsql: Fix incorrect math in DetermineSafeOldestOffset.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix incorrect math in DetermineSafeOldestOffset.
Date: 2015-05-07 15:19:49
Message-ID: E1YqNaX-0005YY-LE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix incorrect math in DetermineSafeOldestOffset.

The old formula didn't have enough parentheses, so it would do the wrong
thing, and it used / rather than % to find a remainder. The effect of
these oversights is that the stop point chosen by the logic introduced in
commit b69bf30b9bfacafc733a9ba77c9587cf54d06c0c might be rather
meaningless.

Thomas Munro, reviewed by Kevin Grittner, with a whitespace tweak by me.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/83fbd9b59906c8543c165c738fc449af24491e63

Modified Files
--------------
src/backend/access/transam/multixact.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-05-07 16:02:27 pgsql: Improve BRIN infra, minmax opclass and regression test
Previous Message Bruce Momjian 2015-05-07 14:26:15 pgsql: Makefile: Add comment that doc uninstall clears man directories