From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix crasher bugs in previous commit |
Date: | 2015-03-09 20:03:33 |
Message-ID: | E1YV3tl-0004QG-Ma@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix crasher bugs in previous commit
ALTER DEFAULT PRIVILEGES was trying to decode the list of roles in the
FOR clause as a list of names rather than of RoleSpecs; and the IN
clause in CREATE ROLE was doing the same thing. This was evidenced by
crashes on some buildfarm machines, though on my platform this doesn't
cause a failure by mere chance; I can reproduce the failures only by
adding some padding in struct RoleSpecs.
Fix by dereferencing those lists as being of RoleSpecs, not string
Values.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/e3f1c24b992acb88e4ccf33118640aee4b11dd47
Modified Files
--------------
src/backend/catalog/aclchk.c | 20 ++++++++++----------
src/backend/commands/user.c | 8 ++++++--
2 files changed, 16 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-03-09 20:44:41 | pgsql: Keep CommitTs module in sync in standby and master |
Previous Message | Alvaro Herrera | 2015-03-09 19:16:47 | Re: pgsql: Allow CURRENT/SESSION_USER to be used in certain commands |