From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Minor cleanup of column-level priv fix |
Date: | 2015-02-17 20:37:19 |
Message-ID: | E1YNotT-0000gJ-BV@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Minor cleanup of column-level priv fix
Commit 9406884af19e2620a14059e64d4eb6ab430ab328 cleaned up
column-privilege related leaks in various error-message paths, but ended
up including a few more things than it should have in the back branches.
Specifically, there's no need for the GetModifiedColumns macro in
execMain.c as 9.1 and older didn't include the row in check constraint
violations. Further, the regression tests added to check those cases
aren't necessary.
This patch removes the GetModifiedColumns macro from execMain.c, removes
the comment which was added to trigger.c related to the duplicate macro
definition, and removes the check-constraint-related regression tests.
Pointed out by Robert.
Back-patched to 9.1 and 9.0.
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/2ed7ef9219f24e99f416b120b1f1841c375c1b51
Modified Files
--------------
src/backend/commands/trigger.c | 6 ------
src/backend/executor/execMain.c | 9 ---------
src/test/regress/expected/privileges.out | 8 --------
src/test/regress/sql/privileges.sql | 4 ----
4 files changed, 27 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-02-17 21:00:30 | pgsql: Fix knn-GiST queue comparison function to return heap tuples fir |
Previous Message | Tom Lane | 2015-02-17 17:49:59 | pgsql: Remove code to match IPv4 pg_hba.conf entries to IPv4-in-IPv6 ad |