From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Avoid returning undefined bytes in chkpass_in(). |
Date: | 2015-02-14 17:21:01 |
Message-ID: | E1YMgOr-0008Ow-C0@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid returning undefined bytes in chkpass_in().
We can't really fix the problem that the result is defined to depend on
random(), so it is still going to fail the "unstable input conversion"
test in parse_type.c. However, we can at least satify valgrind. (It
looks like this code used to be valgrind-clean, actually, until somebody
did a careless s/strncpy/strlcpy/g on it.)
In passing, let's just make real sure that chkpass_out doesn't overrun
its output buffer.
No need for backpatch, I think, since this is just to satisfy debugging
tools.
Asif Naeem
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/80986e85aafd64165efc7f45b330f2f213713032
Modified Files
--------------
contrib/chkpass/chkpass.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2015-02-15 02:36:11 | pgsql: pg_regress: Write processed input/*.source into output dir |
Previous Message | Heikki Linnakangas | 2015-02-13 21:59:09 | pgsql: Fix broken #ifdef for __sparcv8 |