| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Check DCH_MAX_ITEM_SIZ limits with <=, not <. |
| Date: | 2015-02-07 04:44:34 |
| Message-ID: | E1YJxFy-00036G-3R@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Check DCH_MAX_ITEM_SIZ limits with <=, not <.
We reserve space for the full amount, not one less. The affected checks
deal with localized month and day names. Today's DCH_MAX_ITEM_SIZ value
would suffice for a 60-byte day name, while the longest known is the
49-byte mn_CN.utf-8 word for "Saturday." Thus, the upshot of this
change is merely to avoid misdirecting future readers of the code; users
are not expected to see errors either way.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/237795a7b4ccf359423bdd99476782d4880eda83
Modified Files
--------------
src/backend/utils/adt/formatting.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-02-09 06:16:28 | pgsql: Move pg_lzcompress.c to src/common. |
| Previous Message | Bruce Momjian | 2015-02-07 00:48:53 | Security commits |