pgsql: Fix breakage in GEODEBUG debug code.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix breakage in GEODEBUG debug code.
Date: 2015-02-03 20:21:04
Message-ID: E1YIjy4-0005Mn-Ae@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix breakage in GEODEBUG debug code.

LINE doesn't have an "m" field (anymore anyway). Also fix unportable
assumption that %x can print the result of pointer subtraction.

In passing, improve single_decode() in minor ways:
* Remove unnecessary leading-whitespace skip (strtod does that already).
* Make GEODEBUG message more intelligible.
* Remove entirely-useless test to see if strtod returned a silly pointer.
* Don't bother computing trailing-whitespace skip unless caller wants
an ending pointer.

This has been broken since 261c7d4b653bc3e44c31fd456d94f292caa50d8f.
Although it's only debug code, might as well fix the 9.4 branch too.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/778d498c7d9099c784f14199a319ec2a84d91191

Modified Files
--------------
src/backend/utils/adt/geo_ops.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-02-03 21:16:11 pgsql: Use a nonblocking socket for FE/BE communication and block using
Previous Message Heikki Linnakangas 2015-02-03 17:58:30 pgsql: Add API functions to libpq to interrogate SSL related stuff.