pgsql: Fix NUMERIC field access macros to treat NaNs consistently.

Fix NUMERIC field access macros to treat NaNs consistently.

Commit 145343534c153d1e6c3cff1fa1855787684d9a38 arranged to store numeric
NaN values as short-header numerics, but the field access macros did not
get the memo: they thought only "SHORT" numerics have short headers.

Most of the time this makes no difference because we don't access the
weight or dscale of a NaN; but numeric_send does that. As pointed out
by Andrew Gierth, this led to fetching uninitialized bytes.

AFAICS this could not have any worse consequences than that; in particular,
an unaligned stored numeric would have been detoasted by PG_GETARG_NUMERIC,
so that there's no risk of a fetch off the end of memory. Still, the code
is wrong on its own terms, and it's not hard to foresee future changes that
might expose us to real risks. So back-patch to all affected branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1a2b2034d48d46ec3d128b167cb7df317b4cd49a

Modified Files
--------------
src/backend/utils/adt/numeric.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)