From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Tweak BRIN minmax operator class |
Date: | 2015-01-22 20:03:19 |
Message-ID: | E1YENyJ-0001fD-Ft@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tweak BRIN minmax operator class
In the union support proc, we were not checking the hasnulls flag of
value A early enough, so it could be skipped if the "allnulls" flag in
value B is set. Also, a check on the allnulls flag of value "B" was
redundant, so remove it.
Also change inet_minmax_ops to not be the default opclass for type inet,
as a future inclusion operator class would be more useful and it's
pretty difficult to change default opclass for a datatype later on.
(There is no catversion bump for this catalog change; this shouldn't be
a problem.)
Extracted from a larger patch to add an "inclusion" operator class.
Author: Emre Hasegeli
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/972bf7d6f13005dfe89ae3f8a3b937a4a0580c85
Modified Files
--------------
src/backend/access/brin/brin_minmax.c | 19 ++++++++++---------
src/include/catalog/pg_opclass.h | 2 +-
src/test/regress/expected/brin.out | 2 +-
src/test/regress/sql/brin.sql | 2 +-
4 files changed, 13 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2015-01-22 21:57:35 | pgsql: Fix whitespace |
Previous Message | Bruce Momjian | 2015-01-22 18:30:13 | pgsql: docs: update libpq's PQputCopyData and PQputCopyEnd |