pgsql: Allow CFLAGS from configure's environment to override automatic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Allow CFLAGS from configure's environment to override automatic
Date: 2015-01-14 16:08:24
Message-ID: E1YBQUa-0000Kz-KF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow CFLAGS from configure's environment to override automatic CFLAGS.

Previously, configure would add any switches that it chose of its own
accord to the end of the user-specified CFLAGS string. Since most
compilers process these left-to-right, this meant that configure's choices
would override the user-specified flags in case of conflicts. We'd rather
that worked the other way around, so adjust the logic to put the user's
string at the end not the beginning.

There does not seem to be a need for a similar behavior change for CPPFLAGS
or LDFLAGS: in those, the earlier switches tend to win (think -I or -L
behavior) so putting the user's string at the front is fine.

Backpatch to 9.4 but not earlier. I'm not planning to run buildfarm member
guar on older branches, and it seems a bit risky to change this behavior
in long-stable branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/85a2a8903f7e9151793308d0638621003aded5ae

Modified Files
--------------
configure | 13 +++++++++++--
configure.in | 13 +++++++++++--
2 files changed, 22 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-01-14 17:53:13 pgsql: Add a default local latch for use in signal handlers.
Previous Message Tom Lane 2015-01-14 03:52:30 pgsql: Remove duplicate specification of -Ae for HP-UX C compiler.