From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga |
Date: | 2015-01-13 23:47:46 |
Message-ID: | E1YBBBa-00023M-Qp@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make logging_collector=on work with non-windows EXEC_BACKEND again.
Commit b94ce6e80 reordered postmaster's startup sequence so that the
tempfile directory is only cleaned up after all the necessary state
for pg_ctl is collected. Unfortunately the chosen location is after
the syslogger has been started; which normally is fine, except for
!WIN32 EXEC_BACKEND builds, which pass information to children via
files in the temp directory.
Move the call to RemovePgTempFiles() to just before the syslogger has
started. That's the first child we fork.
Luckily EXEC_BACKEND is pretty much only used by endusers on windows,
which has a separate method to pass information to children. That
means the real world impact of this bug is very small.
Discussion: 20150113182344(dot)GF12272(at)alap3(dot)anarazel(dot)de
Backpatch to 9.1, just as the previous commit was.
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/741b1b22a2c09449b3be8af25e18b53190fc8c77
Modified Files
--------------
src/backend/postmaster/postmaster.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2015-01-14 01:26:21 | Re: pgsql: Make path to pg_service.conf absolute in documentation |
Previous Message | Andres Freund | 2015-01-13 23:47:44 | pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga |