pgsql: Provide a generic fallback for pg_compiler_barrier using an exte

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Provide a generic fallback for pg_compiler_barrier using an exte
Date: 2015-01-11 00:21:14
Message-ID: E1YA6HK-0000Q8-O1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Provide a generic fallback for pg_compiler_barrier using an extern function.

If the compiler/arch combination does not provide compiler barriers,
provide a fallback. That fallback simply consists out of a function
call into a externally defined function. That should guarantee
compiler barrierer semantics except for compilers that do inter
translation unit/global optimization - those better provide an actual
compiler barrier.

Hopefully this fixes Tom's report of linker failures due to
pg_compiler_barrier_impl not being provided.

I'm not backpatching this commit as it builds on the new atomics
infrastructure. If we decide an equivalent fix needs to be
backpatched, I'll do so in a separate commit.

Discussion: 27746(dot)1420930690(at)sss(dot)pgh(dot)pa(dot)us

Per report from Tom Lane.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/de6429a8fdd3538e977b482d90389785d733e373

Modified Files
--------------
src/backend/port/atomics.c | 8 ++++++++
src/include/port/atomics/fallback.h | 16 ++++++++++++++++
2 files changed, 24 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-01-11 17:36:00 pgsql: Fix libpq's behavior when /etc/passwd isn't readable.
Previous Message Bruce Momjian 2015-01-10 00:20:37 Re: pgsql: Fix documentation template for CREATE TRIGGER.