pgsql: Correctly handle test durations of more than 2147s in pg_test_ti

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Correctly handle test durations of more than 2147s in pg_test_ti
Date: 2015-01-04 15:10:11
Message-ID: E1Y7mol-0008Lc-4O@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Correctly handle test durations of more than 2147s in pg_test_timing.

Previously the computation of the total test duration, measured in
microseconds, accidentally overflowed due to accidentally using signed
32bit arithmetic. As the only consequence is that pg_test_timing
invocations with such, overly large, durations never finished the
practical consequences of this bug are minor.

Pointed out by Coverity.

Backpatch to 9.2 where pg_test_timing was added.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7ced1b6c52b0e933813af7389c6ff77cf699f564

Modified Files
--------------
contrib/pg_test_timing/pg_test_timing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-01-04 15:10:12 pgsql: Correctly handle test durations of more than 2147s in pg_test_ti
Previous Message Andres Freund 2015-01-04 15:10:08 pgsql: Correctly handle test durations of more than 2147s in pg_test_ti