pgsql: Fix SHLIB_PREREQS use in contrib, allowing PGXS builds

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix SHLIB_PREREQS use in contrib, allowing PGXS builds
Date: 2014-12-04 16:35:27
Message-ID: E1XwZNH-0007f1-P4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix SHLIB_PREREQS use in contrib, allowing PGXS builds

dblink and postgres_fdw use SHLIB_PREREQS = submake-libpq to build libpq
first. This doesn't work in a PGXS build, because there is no libpq to
build. So just omit setting SHLIB_PREREQS in this case.

Note that PGXS users can still use SHLIB_PREREQS (although it is not
documented). The problem here is only that contrib modules can be built
in-tree or using PGXS, and the prerequisite is only applicable in the
former case.

Commit 6697aa2bc25c83b88d6165340348a31328c35de6 previously attempted to
address this by creating a somewhat fake submake-libpq target in
Makefile.global. That was not the right fix, and it was also done in a
nonportable way, so revert that.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/4e4b9002498b72c7000a675216470e8918fc0420

Modified Files
--------------
contrib/dblink/Makefile | 2 +-
contrib/postgres_fdw/Makefile | 2 +-
src/Makefile.global.in | 12 +-----------
3 files changed, 3 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alex Shulgin 2014-12-04 16:47:24 Re: [COMMITTERS] pgsql: Keep track of transaction commit timestamps
Previous Message Alex Shulgin 2014-12-04 15:14:47 Re: [COMMITTERS] pgsql: Keep track of transaction commit timestamps