pgsql: Install kludges to fix check-world for src/test/modules

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Install kludges to fix check-world for src/test/modules
Date: 2014-12-03 02:44:45
Message-ID: E1Xvzvp-000564-Mb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Install kludges to fix check-world for src/test/modules

check-world failed in a completely clean tree, because src/test/modules
fail to build unless errcodes.h is generated first. To fix this,
install a dependency in src/test/modules' Makefile so that the necessary
file is generated. Even with this, running "make check" within
individual module subdirs will still fail because the dependency is not
considered there, but this case is less interesting and would be messier
to fix.

check-world still failed with the above fix in place, this time because
dummy_seclabel used LOAD to load the dynamic library, which doesn't work
because the @libdir@ (expanded by the makefile) is expanded to the final
install path, not the temporary installation directory used by make
check. To fix, tweak things so that CREATE EXTENSION can be used
instead, which solves the problem because the library path is expanded
by the backend, which is aware of the true libdir.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/da34731bd3c805ab77d6e5914d02b1f011e9479d

Modified Files
--------------
src/test/modules/Makefile | 5 ++
src/test/modules/dummy_seclabel/Makefile | 3 +
.../modules/dummy_seclabel/dummy_seclabel--1.0.sql | 9 ++
src/test/modules/dummy_seclabel/dummy_seclabel.c | 12 +++
.../modules/dummy_seclabel/dummy_seclabel.control | 4 +
.../modules/dummy_seclabel/expected/.gitignore | 1 -
.../dummy_seclabel/expected/dummy_seclabel.out | 87 ++++++++++++++++++++
.../dummy_seclabel/input/dummy_seclabel.source | 79 ------------------
.../dummy_seclabel/output/dummy_seclabel.source | 87 --------------------
src/test/modules/dummy_seclabel/sql/.gitignore | 1 -
.../modules/dummy_seclabel/sql/dummy_seclabel.sql | 79 ++++++++++++++++++
11 files changed, 199 insertions(+), 168 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-12-03 02:45:47 Re: pgsql: Move security_label test
Previous Message Tom Lane 2014-12-02 23:23:44 pgsql: Improve error messages for malformed array input strings.