pgsql: Don't skip SQL backends in logical decoding for visibility compu

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't skip SQL backends in logical decoding for visibility compu
Date: 2014-12-02 23:04:21
Message-ID: E1XvwUX-0001cX-V3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't skip SQL backends in logical decoding for visibility computation.

The logical decoding patchset introduced PROC_IN_LOGICAL_DECODING flag
PGXACT flag, that allows such backends to be skipped when computing
the xmin horizon/snapshots. That's fine and sensible for walsenders
streaming out logical changes, but not at all fine for SQL backends
doing logical decoding. If the latter set that flag any change they
have performed outside of logical decoding will not be regarded as
visible - which e.g. can lead to that change being vacuumed away.

Note that not setting the flag for SQL backends isn't particularly
bothersome - the SQL backend doesn't do streaming, so it only runs for
a limited amount of time.

Per buildfarm member 'tick' and Alvaro.

Backpatch to 9.4, where logical decoding was introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/10f1f93d8ae2d70fcaf350c62972fb6bac42ffc9

Modified Files
--------------
contrib/test_decoding/expected/decoding_into_rel.out | 2 ++
contrib/test_decoding/sql/decoding_into_rel.sql | 4 ++++
src/backend/replication/logical/logical.c | 15 ++++++++++++---
src/include/storage/proc.h | 2 +-
4 files changed, 19 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-12-02 23:23:44 pgsql: Improve error messages for malformed array input strings.
Previous Message Andres Freund 2014-12-02 23:04:19 pgsql: Don't skip SQL backends in logical decoding for visibility compu