pgsql: Fix xmin/xmax horizon computation during logical decoding initia

Fix xmin/xmax horizon computation during logical decoding initialization.

When building the initial historic catalog snapshot there were
scenarios where snapbuild.c would use incorrect xmin/xmax values when
starting from a xl_running_xacts record. The values used were always a
bit suspect, but happened to be correct in the easy to test
cases. Notably the values used when the the initial snapshot was
computed while no other transactions were running were correct.

This is likely to be the cause of the occasional buildfarm failures on
animals markhor and tick; but it's quite possible to reproduce
problems without CLOBBER_CACHE_ALWAYS.

Backpatch to 9.4, where logical decoding was introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/da668a5d8f92af33d1f01b20993f4e1cf3735973

Modified Files
--------------
src/backend/replication/logical/snapbuild.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)