| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix building with WAL_DEBUG. |
| Date: | 2014-11-07 21:09:52 |
| Message-ID: | E1Xmqn2-00030g-39@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix building with WAL_DEBUG.
Now that the backup blocks are appended to the WAL record in xloginsert.c,
XLogInsert doesn't see them anymore and cannot remove them from the version
reconstructed for xlog_outdesc. This makes running with wal_debug=on more
expensive, as we now make (unnecessary) temporary copies of the backup
blocks, but it doesn't seem worth convoluting the code to keep that
optimization.
Reported by Alvaro Herrera.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/7250d8535b11d6443a9b27299e586c3df0654302
Modified Files
--------------
src/backend/access/transam/xlog.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-11-07 21:10:15 | Re: pgsql: Move the backup-block logic from XLogInsert to a new file, xlogi |
| Previous Message | Robert Haas | 2014-11-07 20:51:30 | pgsql: Use the sortsupport infrastructure in more cases. |