pgsql: Avoid unportable strftime() behavior in pg_dump/pg_dumpall.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid unportable strftime() behavior in pg_dump/pg_dumpall.
Date: 2014-10-27 00:59:28
Message-ID: E1XiYee-0004l6-1S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid unportable strftime() behavior in pg_dump/pg_dumpall.

Commit ad5d46a4494b0b480a3af246bb4227d9bdadca37 thought that we could
get around the known portability issues of strftime's %Z specifier by
using %z instead. However, that idea seems to have been innocent of
any actual research, as it certainly missed the facts that
(1) %z is not portable to pre-C99 systems, and
(2) %z doesn't actually act differently from %Z on Windows anyway.

Per failures on buildfarm member hamerkop.

While at it, centralize the code defining what strftime format we
want to use in pg_dump; three copies of that string seems a bit much.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f455fcfdb8ca3b67373223a4e15648c35e2592a9

Modified Files
--------------
src/bin/pg_dump/dumputils.h | 17 +++++++++++++++++
src/bin/pg_dump/pg_backup_archiver.c | 8 +++++---
src/bin/pg_dump/pg_dumpall.c | 6 +++---
3 files changed, 25 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-10-27 08:46:04 pgsql: Add variable names to two LWLock C prototypes
Previous Message Tom Lane 2014-10-26 23:18:04 pgsql: Fix undersized result buffer in pset_quoted_string().