pgsql: Don't duplicate log_checkpoint messages for both of restart and

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't duplicate log_checkpoint messages for both of restart and
Date: 2014-10-20 23:03:42
Message-ID: E1XgLzK-00033z-IY@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't duplicate log_checkpoint messages for both of restart and checkpoints.

The duplication originated in cdd46c765, where restartpoints were
introduced.

In LogCheckpointStart's case the duplication actually lead to the
compiler's format string checking not to be effective because the
format string wasn't constant.

Arguably these messages shouldn't be elog(), but ereport() style
messages. That'd even allow to translate the messages... But as
there's more mistakes of that kind in surrounding code, it seems
better to change that separately.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5e5b65f359b7a12c05708585a8e6cd4d80ca2652

Modified Files
--------------
src/backend/access/transam/xlog.c | 62 +++++++++++--------------------------
1 file changed, 18 insertions(+), 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2014-10-21 05:38:43 Re: pgsql: doc: restrictions on alter database moving default tablespace
Previous Message Andres Freund 2014-10-20 22:26:36 pgsql: Renumber CHECKPOINT_* flags.