From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix core dump in pg_dump --binary-upgrade on zero-column composi |
Date: | 2014-10-17 16:49:52 |
Message-ID: | E1XfAiu-0005Na-QS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix core dump in pg_dump --binary-upgrade on zero-column composite type.
This reverts nearly all of commit 28f6cab61ab8958b1a7dfb019724687d92722538
in favor of just using the typrelid we already have in pg_dump's TypeInfo
struct for the composite type. As coded, it'd crash if the composite type
had no attributes, since then the query would return no rows.
Back-patch to all supported versions. It seems to not really be a problem
in 9.0 because that version rejects the syntax "create type t as ()", but
we might as well keep the logic similar in all affected branches.
Report and fix by Rushabh Lathia.
Branch
------
REL9_2_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/787e20bd4a33fd076cad1fd3ec58c644a14d8390
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2014-10-17 18:08:26 | pgsql: Fix bug in handling of connections that pg_receivexlog creates. |
Previous Message | Tom Lane | 2014-10-17 16:19:11 | pgsql: Re-pgindent src/bin/pg_dump/*. |