pgsql: Print planning time only in EXPLAIN ANALYZE, not plain EXPLAIN.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Print planning time only in EXPLAIN ANALYZE, not plain EXPLAIN.
Date: 2014-10-15 22:50:24
Message-ID: E1XeXOi-0005Mw-B7@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Print planning time only in EXPLAIN ANALYZE, not plain EXPLAIN.

We've gotten enough push-back on that change to make it clear that it
wasn't an especially good idea to do it like that. Revert plain EXPLAIN
to its previous behavior, but keep the extra output in EXPLAIN ANALYZE.
Per discussion.

Internally, I set this up as a separate flag ExplainState.summary that
controls printing of planning time and execution time. For now it's
just copied from the ANALYZE option, but we could consider exposing it
to users.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9bb6b7c5ed617b34edf1a962c9405359822418d3

Modified Files
--------------
contrib/auto_explain/auto_explain.c | 1 +
doc/src/sgml/perform.sgml | 25 ++++++-------------------
doc/src/sgml/ref/explain.sgml | 19 +++++++------------
src/backend/commands/explain.c | 10 +++++++---
src/include/commands/explain.h | 5 +++--
5 files changed, 24 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-10-16 19:22:59 pgsql: Support timezone abbreviations that sometimes change.
Previous Message Alvaro Herrera 2014-10-14 20:43:39 Re: pgsql: pg_dump: Reduce use of global variables