pgsql: Revert 95d737ff to add 'ignore_nulls'

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert 95d737ff to add 'ignore_nulls'
Date: 2014-09-29 17:33:27
Message-ID: E1XYepD-0004CD-7T@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert 95d737ff to add 'ignore_nulls'

Per discussion, revert the commit which added 'ignore_nulls' to
row_to_json. This capability would be better added as an independent
function rather than being bolted on to row_to_json. Additionally,
the implementation didn't address complex JSON objects, and so was
incomplete anyway.

Pointed out by Tom and discussed with Andrew and Robert.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c8a026e4f15e2063cd7fe6cb9ffe44f2a81398bd

Modified Files
--------------
doc/src/sgml/func.sgml | 6 ++--
src/backend/catalog/system_views.sql | 14 --------
src/backend/utils/adt/json.c | 55 +++++++++++++++++++++++---------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 8 +++--
src/include/utils/json.h | 2 ++
src/test/regress/expected/json.out | 58 ----------------------------------
src/test/regress/sql/json.sql | 24 --------------
8 files changed, 51 insertions(+), 118 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-09-29 17:59:14 Re: pgsql: Change JSONB's on-disk format for improved performance.
Previous Message Andrew Dunstan 2014-09-29 17:16:57 Re: pgsql: Change JSONB's on-disk format for improved performance.