pgsql: Further atomic ops portability improvements and bug fixes.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Further atomic ops portability improvements and bug fixes.
Date: 2014-09-26 15:12:40
Message-ID: E1XXXCK-0006el-2S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Further atomic ops portability improvements and bug fixes.

* Don't play tricks for a more efficient pg_atomic_clear_flag() in the
generic gcc implementation. The old version was broken on gcc < 4.7
on !x86 platforms. Per buildfarm member chipmunk.
* Make usage of __atomic() fences depend on HAVE_GCC__ATOMIC_INT32_CAS
instead of HAVE_GCC__ATOMIC_INT64_CAS - there's platforms with 32bit
support that don't support 64bit atomics.
* Blindly fix two superflous #endif in generic-xlc.h
* Check for --disable-atomics in platforms but x86.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f9f07411a5b879b232ade66fece7071bd2eb5c26

Modified Files
--------------
src/include/port/atomics/arch-x86.h | 13 +++++++++++++
src/include/port/atomics/generic-acc.h | 11 ++++++++++-
src/include/port/atomics/generic-gcc.h | 14 ++++----------
src/include/port/atomics/generic-msvc.h | 8 ++++++++
src/include/port/atomics/generic-sunpro.h | 8 ++++++++
src/include/port/atomics/generic-xlc.h | 10 ++++++++--
6 files changed, 51 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-09-26 15:49:47 pgsql: Fix identify_locking_dependencies for schema-only dumps.
Previous Message Andres Freund 2014-09-26 07:37:48 pgsql: Fix a couple occurrences of 'the the' in the new atomics API.