pgsql: Fix failure of contrib/auto_explain to print per-node timing inf

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix failure of contrib/auto_explain to print per-node timing inf
Date: 2014-09-19 17:19:36
Message-ID: E1XV1qK-0005F5-Um@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix failure of contrib/auto_explain to print per-node timing information.

This has been broken since commit af7914c6627bcf0b0ca614e9ce95d3f8056602bf,
which added the EXPLAIN (TIMING) option. Although that commit included
updates to auto_explain, they evidently weren't tested very carefully,
because the code failed to print node timings even when it should, due to
failure to set es.timing in the ExplainState struct. Reported off-list by
Neelakanth Nadgir of Salesforce.

In passing, clean up the documentation for auto_explain's options a
little bit, including re-ordering them into what seems to me a more
logical order.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/47288bd08c0169ecb5eb50742336cc0df813777e

Modified Files
--------------
contrib/auto_explain/auto_explain.c | 5 +--
doc/src/sgml/auto-explain.sgml | 77 ++++++++++++++++++++---------------
2 files changed, 46 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2014-09-20 03:57:22 Re: pgsql: Allow units to be specified in relation option setting value.
Previous Message Robert Haas 2014-09-19 17:13:15 pgsql: doc: Use <literal> and all-caps for READ COMMITTED isolation lev