pgsql: Check number of parameters in RAISE statement at compile time.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Check number of parameters in RAISE statement at compile time.
Date: 2014-09-02 13:00:29
Message-ID: E1XOnhF-0000et-3R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check number of parameters in RAISE statement at compile time.

The number of % parameter markers in RAISE statement should match the number
of parameters given. We used to check that at execution time, but we have
all the information needed at compile time, so let's check it at compile
time instead. It's generally better to find mistakes earlier.

Marko Tiikkaja, reviewed by Fabien Coelho

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c1008f0037ec9c738127c2fa6d7f6c88d885f45f

Modified Files
--------------
doc/src/sgml/plpgsql.sgml | 3 +++
src/pl/plpgsql/src/pl_exec.c | 14 ++++--------
src/pl/plpgsql/src/pl_gram.y | 38 +++++++++++++++++++++++++++++++++
src/test/regress/expected/plpgsql.out | 19 +++++++++++++----
src/test/regress/sql/plpgsql.sql | 11 +++++++---
5 files changed, 68 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-09-03 15:54:36 pgsql: Issue clearer notice when inherited merged columns are moved
Previous Message Heikki Linnakangas 2014-09-02 12:20:38 pgsql: Refactor per-page logic common to all redo routines to a new fun