pgsql: Declare lwlock.c's LWLockAcquireCommon() as a static inline.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Declare lwlock.c's LWLockAcquireCommon() as a static inline.
Date: 2014-08-31 22:17:38
Message-ID: E1XODRK-0005rs-S6@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Declare lwlock.c's LWLockAcquireCommon() as a static inline.

68a2e52bbaf98f136 has introduced LWLockAcquireCommon() containing the
previous contents of LWLockAcquire() plus added functionality. The
latter then calls it, just like LWLockAcquireWithVar(). Because the
majority of callers don't need the added functionality, declare the
common code as inline. The compiler then can optimize away the unused
code. Doing so is also useful when looking at profiles, to
differentiate the users.

Backpatch to 9.4, the first branch to contain LWLockAcquireCommon().

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9c4b55db1dc901dc184b1b3ab9cca3f2089ec311

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-08-31 22:17:41 pgsql: Declare lwlock.c's LWLockAcquireCommon() as a static inline.
Previous Message Andres Freund 2014-08-31 22:04:04 pgsql: Protect definition of SpinlockSemaArray, just like its declarati