pgsql: Rework 'MOVE ALL' to 'ALTER .. ALL IN TABLESPACE'

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rework 'MOVE ALL' to 'ALTER .. ALL IN TABLESPACE'
Date: 2014-08-21 23:13:28
Message-ID: E1XKbXs-0008DY-26@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rework 'MOVE ALL' to 'ALTER .. ALL IN TABLESPACE'

As 'ALTER TABLESPACE .. MOVE ALL' really didn't change the tablespace
but instead changed objects inside tablespaces, it made sense to
rework the syntax and supporting functions to operate under the
'ALTER (TABLE|INDEX|MATERIALIZED VIEW)' syntax and to be in
tablecmds.c.

Pointed out by Alvaro, who also suggested the new syntax.

Back-patch to 9.4.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3c4cf080879b386d4ed1814667aca025caafe608

Modified Files
--------------
doc/src/sgml/ref/alter_index.sgml | 13 ++
doc/src/sgml/ref/alter_materialized_view.sgml | 2 +
doc/src/sgml/ref/alter_table.sgml | 20 ++-
doc/src/sgml/ref/alter_tablespace.sgml | 78 -----------
doc/src/sgml/release-9.4.sgml | 5 +-
src/backend/commands/tablecmds.c | 171 +++++++++++++++++++++++
src/backend/commands/tablespace.c | 179 -------------------------
src/backend/nodes/copyfuncs.c | 11 +-
src/backend/nodes/equalfuncs.c | 9 +-
src/backend/parser/gram.y | 165 ++++++++++-------------
src/backend/tcop/utility.c | 20 ++-
src/include/commands/tablecmds.h | 2 +
src/include/commands/tablespace.h | 1 -
src/include/nodes/nodes.h | 2 +-
src/include/nodes/parsenodes.h | 7 +-
src/test/regress/input/tablespace.source | 5 +-
src/test/regress/output/tablespace.source | 5 +-
src/tools/pgindent/typedefs.list | 2 +-
18 files changed, 305 insertions(+), 392 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2014-08-22 01:25:05 Re: pgsql: Add pinning_backends column to the pg_buffercache extension.
Previous Message Andres Freund 2014-08-21 22:29:04 pgsql: Add pinning_backends column to the pg_buffercache extension.