pgsql: Don't assume a subquery's output is unique if there's a SRF in i

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't assume a subquery's output is unique if there's a SRF in i
Date: 2014-07-08 18:04:06
Message-ID: E1X4ZkM-0002sr-Dr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't assume a subquery's output is unique if there's a SRF in its tlist.

While the x output of "select x from t group by x" can be presumed unique,
this does not hold for "select x, generate_series(1,10) from t group by x",
because we may expand the set-returning function after the grouping step.
(Perhaps that should be re-thought; but considering all the other oddities
involved with SRFs in targetlists, it seems unlikely we'll change it.)
Put a check in query_is_distinct_for() so it's not fooled by such cases.

Back-patch to all supported branches.

David Rowley

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6d36aee5b718524f718436d0973822bc2cb30bdd

Modified Files
--------------
src/backend/optimizer/util/pathnode.c | 11 +++++++++++
src/test/regress/expected/subselect.out | 33 +++++++++++++++++++++++++++++++
src/test/regress/sql/subselect.sql | 9 +++++++++
3 files changed, 53 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2014-07-08 18:45:33 pgsql: doc: Link text to table by id
Previous Message Peter Eisentraut 2014-07-08 15:56:18 pgsql: doc: Fix spacing in verbatim environments