pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar
Date: 2014-07-03 22:26:15
Message-ID: E1X2pSJ-0002B9-By@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Redesign API presented by nodeAgg.c for ordered-set and similar aggregates.

The previous design exposed the input and output ExprContexts of the
Agg plan node, but work on grouping sets has suggested that we'll regret
doing that. Instead provide more narrowly-defined APIs that can be
implemented in multiple ways, namely a way to get a short-term memory
context and a way to register an aggregate shutdown callback.

Back-patch to 9.4 where the bad APIs were introduced, since we don't
want third-party code using these APIs and then having to change in 9.5.

Andrew Gierth

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f688cf548b3e37991009b7a3607171242c796e62

Modified Files
--------------
src/backend/executor/nodeAgg.c | 38 +++++++++++++++++++++-----------
src/backend/utils/adt/orderedsetaggs.c | 16 ++++----------
src/include/fmgr.h | 8 ++++---
3 files changed, 34 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-07-03 22:47:28 pgsql: Don't cache per-group context across the whole query in ordereds
Previous Message Tom Lane 2014-07-03 20:10:55 pgsql: Improve support for composite types in PL/Python.