pgsql: Prevent psql from issuing BEGIN before ALTER SYSTEM when AUTOCOM

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Prevent psql from issuing BEGIN before ALTER SYSTEM when AUTOCOM
Date: 2014-07-02 04:00:23
Message-ID: E1X2BiZ-0004I0-FK@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Prevent psql from issuing BEGIN before ALTER SYSTEM when AUTOCOMMIT is off.

The autocommit-off mode works by issuing an implicit BEGIN just before
any command that is not already in a transaction block and is not itself
a BEGIN or other transaction-control command, nor a command that
cannot be executed inside a transaction block. This commit prevents psql
from issuing such an implicit BEGIN before ALTER SYSTEM because it's
not allowed inside a transaction block.

Backpatch to 9.4 where ALTER SYSTEM was added.

Report by Feike Steenbergen

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5520006b5bbaa36e6734a8ccf960bb870f4a4fec

Modified Files
--------------
src/bin/psql/common.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-07-02 16:31:36 pgsql: Add some errdetail to checkRuleResultList().
Previous Message Tom Lane 2014-07-02 00:10:56 pgsql: Allow CREATE/ALTER DATABASE to manipulate datistemplate and data