pgsql: Don't allow foreign tables with OIDs.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't allow foreign tables with OIDs.
Date: 2014-06-24 10:32:45
Message-ID: E1WzO1t-0004KV-2F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2a7512bc7fd01b311f967e85024fa695a6061e4f

Modified Files
--------------
src/backend/commands/tablecmds.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-06-24 20:11:12 pgsql: pg_upgrade: remove pg_multixact files left by initdb
Previous Message Robert Haas 2014-06-24 02:01:52 pgsql: Check for interrupts during tuple-insertion loops.