pgsql: Don't allow data_directory to be set in postgresql.auto.conf by

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't allow data_directory to be set in postgresql.auto.conf by
Date: 2014-06-19 11:50:55
Message-ID: E1Wxarn-00060I-Hn@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't allow data_directory to be set in postgresql.auto.conf by ALTER SYSTEM.

data_directory could be set both in postgresql.conf and postgresql.auto.conf so far.
This could cause some problematic situations like circular definition. To avoid such
situations, this commit forbids a user to set data_directory in postgresql.auto.conf.

Backpatch this to 9.4 where ALTER SYSTEM command was introduced.

Amit Kapila, reviewed by Abhijit Menon-Sen, with minor adjustments by me.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/fc5cf383d9ae894e3c9e94701ce5dc468d334433

Modified Files
--------------
doc/src/sgml/ref/alter_system.sgml | 10 ++++++++++
src/backend/utils/misc/guc.c | 21 +++++++++++++++------
src/include/utils/guc.h | 1 +
3 files changed, 26 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2014-06-19 13:56:06 pgsql: Fix calculation of PREDICATELOCK_MANAGER_LWLOCK_OFFSET.
Previous Message Tom Lane 2014-06-19 00:13:14 pgsql: Improve our mechanism for controlling the Linux out-of-memory ki