From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Rename lo_create(oid, bytea) to lo_from_bytea(). |
Date: | 2014-06-12 19:39:25 |
Message-ID: | E1WvAqL-00054X-0J@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Rename lo_create(oid, bytea) to lo_from_bytea().
The previous naming broke the query that libpq's lo_initialize() uses
to collect the OIDs of the server-side functions it requires, because
that query effectively assumes that there is only one function named
lo_create in the pg_catalog schema (and likewise only one lo_open, etc).
While we should certainly make libpq more robust about this, the naive
query will remain in use in the field for the foreseeable future, so it
seems the only workable choice is to use a different name for the new
function. lo_from_bytea() won a small straw poll.
Back-patch into 9.4 where the new function was introduced.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/e3489847d08beaa4b9dc2a84011719f0b848f3e1
Modified Files
--------------
doc/src/sgml/lobj.sgml | 6 +++---
src/backend/libpq/be-fsstubs.c | 4 ++--
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 4 ++--
src/include/libpq/be-fsstubs.h | 2 +-
src/test/regress/input/largeobject.source | 2 +-
src/test/regress/output/largeobject.source | 2 +-
src/test/regress/output/largeobject_1.source | 2 +-
8 files changed, 12 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-06-12 19:54:29 | pgsql: Add regression test to prevent future breakage of legacy query i |
Previous Message | Alvaro Herrera | 2014-06-12 18:02:38 | pgsql: Fix typos |