pgsql: Ensure cleanup in case of early errors in streaming base backups

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Ensure cleanup in case of early errors in streaming base backups
Date: 2014-05-28 11:05:32
Message-ID: E1Wpbfo-0004Eg-1X@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ensure cleanup in case of early errors in streaming base backups

Move the code that sends the initial status information as well as the
calculation of paths inside the ENSURE_ERROR_CLEANUP block. If this code
failed, we would "leak" a counter of number of concurrent backups, thereby
making the system always believe it was in backup mode. This could happen
if the sending failed (which it probably never did given that the small
amount of data to send would never cause a flush). It is very low risk, but
all operations after do_pg_start_backup should be protected.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/dbcde0f4d62815eee8f32c17441db8f5009657db

Modified Files
--------------
src/backend/replication/basebackup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-05-28 15:50:48 pgsql: Fix stack clobber in new uuid-ossp code.
Previous Message Bruce Momjian 2014-05-28 10:27:40 pgsql: doc: improve markup of ssl_ecdh_curve commit