pgsql: Handle duplicate XIDs in txid_snapshot.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Handle duplicate XIDs in txid_snapshot.
Date: 2014-05-15 15:33:17
Message-ID: E1Wkxen-0005ka-VZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle duplicate XIDs in txid_snapshot.

The proc array can contain duplicate XIDs, when a transaction is just being
prepared for two-phase commit. To cope, remove any duplicates in
txid_current_snapshot(). Also ignore duplicates in the input functions, so
that if e.g. you have an old pg_dump file that already contains duplicates,
it will be accepted.

Report and fix by Jan Wieck. Backpatch to all supported versions.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8f9b9590d79fc1fc1ad08b207401acfdbb0bfac7

Modified Files
--------------
src/backend/utils/adt/txid.c | 59 ++++++++++++++++++++++++++++--------
src/test/regress/expected/txid.out | 10 +++---
src/test/regress/sql/txid.sql | 2 +-
3 files changed, 54 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-05-15 15:33:18 pgsql: Handle duplicate XIDs in txid_snapshot.
Previous Message Heikki Linnakangas 2014-05-15 14:18:11 pgsql: Fix race condition in preparing a transaction for two-phase comm