| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Code review for logical decoding patch. |
| Date: | 2014-05-09 14:48:21 |
| Message-ID: | E1Wim61-0008S4-6r@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Code review for logical decoding patch.
Post-commit review identified a number of places where addition was
used instead of multiplication or memory wasn't zeroed where it should
have been. This commit also fixes one case where a structure member
was mis-initialized, and moves another memory allocation closer to
the place where the allocated storage is used for clarity.
Andres Freund
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/f1d8dd3647fd0c87f0fb238f7cfc45c1ce282a55
Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 13 +++++--------
src/backend/replication/logical/snapbuild.c | 11 +++++------
2 files changed, 10 insertions(+), 14 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-05-09 16:55:48 | pgsql: Get rid of bogus dependency on typcategory in to_json() and frie |
| Previous Message | Robert Haas | 2014-05-09 14:43:49 | pgsql: Remove overeager assertion in logical_heap_begin_rewrite. |