From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve key representation for GIN jsonb_ops, and fix existence- |
Date: | 2014-05-09 12:41:34 |
Message-ID: | E1Wik7K-0006TN-OZ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve key representation for GIN jsonb_ops, and fix existence-search bug.
Change the key representation so that values that would exceed 127 bytes
are hashed into short strings, and so that the original JSON datatype of
each value is recorded in the index. The hashing rule eliminates the major
objection to having this opclass be the default for jsonb, namely that it
could fail for plausible input data (due to GIN's restrictions on maximum
key length). Preserving datatype information doesn't really buy us much
right now, but it requires no extra space compared to the previous way,
and it might be useful later.
Also, change the consistency-checking functions to request recheck for
exists (jsonb ? text) and related operators. The original analysis that
this is an exactly checkable query was incorrect, since the index does
not preserve information about whether a key appears at top level in
the indexed JSON object. Add a test case demonstrating the problem.
Make some other, mostly cosmetic improvements to the code in jsonb_gin.c
as well.
catversion bump due to on-disk data format change in jsonb_ops indexes.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/46dddf7673c5820be7c78a8b0e098fdbc65d003d
Modified Files
--------------
src/backend/utils/adt/jsonb_gin.c | 461 ++++++++++++++++-----------------
src/include/catalog/catversion.h | 2 +-
src/include/utils/jsonb.h | 52 ++--
src/test/regress/data/jsonb.data | 3 +
src/test/regress/expected/jsonb.out | 28 +-
src/test/regress/expected/jsonb_1.out | 28 +-
src/test/regress/sql/jsonb.sql | 2 +
7 files changed, 299 insertions(+), 277 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-05-09 12:57:30 | pgsql: More jsonb cleanup. |
Previous Message | Heikki Linnakangas | 2014-05-09 10:12:28 | pgsql: Minor cleanup of jsonb_util.c |