From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Revert "Auto-tune effective_cache size to be 4x shared buffers" |
Date: | 2014-05-09 00:49:53 |
Message-ID: | E1WiZ0b-0003sY-I8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Revert "Auto-tune effective_cache size to be 4x shared buffers"
This reverts commit ee1e5662d8d8330726eaef7d3110cb7add24d058, as well as
a remarkably large number of followup commits, which were mostly concerned
with the fact that the implementation didn't work terribly well. It still
doesn't: we probably need some rather basic work in the GUC infrastructure
if we want to fully support GUCs whose default varies depending on the
value of another GUC. Meanwhile, it also emerged that there wasn't really
consensus in favor of the definition the patch tried to implement (ie,
effective_cache_size should default to 4 times shared_buffers). So whack
it all back to where it was. In a followup commit, I'll do what was
recently agreed to, which is to simply change the default to a higher
value.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/a16d421ca4fc639929bc964b2585e8382cf16e33
Modified Files
--------------
doc/src/sgml/config.sgml | 12 +-----
src/backend/optimizer/path/costsize.c | 51 +------------------------
src/backend/utils/misc/guc-file.l | 1 -
src/backend/utils/misc/guc.c | 7 +---
src/backend/utils/misc/postgresql.conf.sample | 2 +-
src/include/optimizer/cost.h | 2 +
src/include/utils/guc.h | 4 --
src/test/regress/expected/join.out | 1 -
src/test/regress/sql/join.sql | 2 -
9 files changed, 8 insertions(+), 74 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-05-09 01:11:53 | pgsql: Increase the default value of effective_cache_size to 4GB. |
Previous Message | Noah Misch | 2014-05-08 23:38:13 | pgsql: Un-break ecpg test suite under --disable-integer-datetimes. |