From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix interval test, which was broken for floating-point timestamp |
Date: | 2014-05-07 04:33:44 |
Message-ID: | E1WhtY8-0003YB-Rf@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix interval test, which was broken for floating-point timestamps.
Commit 4318daecc959886d001a6e79c6ea853e8b1dfb4b introduced a test that
couldn't be made consistent between integer and floating-point
timestamps.
It was designed to test the longest possible interval output length,
so removing four zeros from the number of hours, as this patch does,
is not ideal. But the test still has some utility for its original
purpose, and there aren't a lot of other good options.
Noah Misch suggested a different approach where we test that the
output either matches what we expect from integer timestamps or what
we expect from floating-point timestamps. That seemed to obscure an
otherwise simple test, however.
Reviewed by Tom Lane and Noah Misch.
Branch
------
REL9_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/b671061e1452ce27dbb9ffe6d56a87874c8bd347
Modified Files
--------------
src/test/regress/expected/interval.out | 11 +++++++----
src/test/regress/sql/interval.sql | 5 ++++-
2 files changed, 11 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2014-05-07 04:38:34 | pgsql: Fix interval test, which was broken for floating-point timestamp |
Previous Message | Tom Lane | 2014-05-07 03:52:35 | pgsql: Fix some more confusion between uint32 and Datum. |