pgsql: Fix interval test, which was broken for floating-point timestamp

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix interval test, which was broken for floating-point timestamp
Date: 2014-05-07 02:54:47
Message-ID: E1Whs0N-00020J-L3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix interval test, which was broken for floating-point timestamps.

Commit 4318daecc959886d001a6e79c6ea853e8b1dfb4b introduced a test that
couldn't be made consistent between integer and floating-point
timestamps.

It was designed to test the longest possible interval output length,
so removing four zeros from the number of hours, as this patch does,
is not ideal. But the test still has some utility for its original
purpose, and there aren't a lot of other good options.

Noah Misch suggested a different approach where we test that the
output either matches what we expect from integer timestamps or what
we expect from floating-point timestamps. That seemed to obscure an
otherwise simple test, however.

Reviewed by Tom Lane and Noah Misch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/348aa75a678069569923c501206d5a1ca03654e3

Modified Files
--------------
src/test/regress/expected/interval.out | 11 +++++++----
src/test/regress/sql/interval.sql | 5 ++++-
2 files changed, 11 insertions(+), 5 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-05-07 03:26:19 Re: pgsql: Fix interval test, which was broken for floating-point timestamp
Previous Message Tom Lane 2014-05-07 02:49:46 pgsql: hash_any returns Datum, not uint32 (and definitely not "int").