pgsql: Prevent interrupts while reporting non-ERROR elog messages.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Prevent interrupts while reporting non-ERROR elog messages.
Date: 2014-03-14 01:00:28
Message-ID: E1WOGU8-0003iu-6R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Prevent interrupts while reporting non-ERROR elog messages.

This should eliminate the risk of recursive entry to syslog(3), which
appears to be the cause of the hang reported in bug #9551 from James
Morton.

Arguably, the real problem here is auth.c's willingness to turn on
ImmediateInterruptOK while executing fairly wide swaths of backend code.
We may well need to work at narrowing the code ranges in which the
authentication_timeout interrupt is enabled. For the moment, though,
this is a cheap and reasonably noninvasive fix for a field-reported
failure; the other approach would be complex and not necessarily
bug-free itself.

Back-patch to all supported branches.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/dad55e1e99dcc0c6b2a75722b3f1106bc68c8960

Modified Files
--------------
src/backend/utils/error/elog.c | 38 +++++++++++++++++++++++++-------------
1 file changed, 25 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-03-14 14:11:01 pgsql: Fix race condition in B-tree page deletion.
Previous Message Tom Lane 2014-03-14 01:00:27 pgsql: Prevent interrupts while reporting non-ERROR elog messages.