pgsql: Remove unportable use of anonymous unions from reorderbuffer.h.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove unportable use of anonymous unions from reorderbuffer.h.
Date: 2014-03-07 22:03:43
Message-ID: E1WM2rn-0002U6-4n@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unportable use of anonymous unions from reorderbuffer.h.

In b89e151054a I had assumed it was ok to use anonymous unions as
struct members, but while a longstanding extension in many compilers,
it's only been standardized in C11.

To fix, remove one of the anonymous unions which tried to hide some
implementation specific enum values and give the other a name. The
latter unfortunately requires changes in output plugins, but since the
feature has only been added a few days ago...

Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ea177a3ba7a7901f6467eadb0a407e03d46462fd

Modified Files
--------------
contrib/test_decoding/test_decoding.c | 18 +-
src/backend/replication/logical/decode.c | 28 +--
src/backend/replication/logical/reorderbuffer.c | 283 +++++++++++------------
src/include/replication/reorderbuffer.h | 39 ++--
4 files changed, 186 insertions(+), 182 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-08 01:56:45 pgsql: docs: improve TABLE command by showing supported clauses
Previous Message Tom Lane 2014-03-07 21:37:26 pgsql: Fix contrib/postgres_fdw to handle multiple join conditions prop