pgsql: isdigit() needs an unsigned char argument.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: isdigit() needs an unsigned char argument.
Date: 2014-03-06 19:41:25
Message-ID: E1WLeAX-0002ji-VL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

isdigit() needs an unsigned char argument.

Per the C standard, the routine should be passed an int, with a value that's
representable as an unsigned char or EOF. Passing a signed char is wrong,
because a negative value is not representable as an unsigned char.
Unfortunately no compiler warns about that.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a0c2fa9b5cfaf9595e8809a68eec929a5052834e

Modified Files
--------------
src/backend/utils/adt/timestamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-03-07 00:31:52 pgsql: Avoid getting more than AccessShareLock when deparsing a query.
Previous Message Tom Lane 2014-03-06 16:37:14 pgsql: Don't reject ROW_MARK_REFERENCE rowmarks for materialized views.